search

akshathjain / sliding_up_panel

A draggable Flutter widget that makes implementing a SlidingUpPanel much easier!
https://pub.dartlang.org/packages/sliding_up_panel
Other
1.38k stars 381 forks source link

Add support for a widget attached on the panel #110

Closed RomanJos closed 4 years ago

RomanJos commented 4 years ago

See #109 Here is my attempt to make it working without calling setState at each move, the panel is now inside a Column with the new widget.

Please note that I'm a beginner at Dart/Flutter so I didn't make a final solution, as you can see at line 311 I created a Column and did panel + attachedWidgets , so if the user don't set it, it would throw an error, and if the panel has slideDirection: SlideDirection.UP, attachedWidgets needs to be at the end of the list but I don't know how to do that :(

Also I formatted using the default flutter format

preetjdp commented 4 years ago

Hey can you add a screenshot here?

(Edited) NVM. image

akshathjain commented 4 years ago

@RomanJos This is a good PR! I'm going to close this only because I believe the solution presented in #109 is a cleaner way to integrate a feature such as this, especially since the use case can vary vastly from user-to-user.