search

akshathjain / sliding_up_panel

A draggable Flutter widget that makes implementing a SlidingUpPanel much easier!
https://pub.dartlang.org/packages/sliding_up_panel
Other
1.38k stars 378 forks source link

Compilation error against dev flutter channel (gestures -> VelocityTracker) #198

Closed dcchristopher closed 4 years ago

dcchristopher commented 4 years ago

Describe the bug The invocation of Flutter gestures library code (VelocityTracker) from within sliding_up_panel is causing a compilation error due to a breaking change (dev channel for now).

To Reproduce Switch to the dev Flutter channel and flutter build

Expected behavior I expect the compilation to succeed.

Screenshots N/A

Additional context Compilation error message: ../../../.pub-cache/hosted/pub.dartlang.org/sliding_up_panel-1.0.2/lib/src/panel.dart:218:44: Error: Too few positional arguments: 1 required, 0 given.

VelocityTracker _vt = new VelocityTracker(); ^

flutter/packages/flutter/lib/src/gestures/velocity_tracker.dart:152:3: Context: Found this candidate, but the arguments don't match.

VelocityTracker(this.kind); ^^^^^^^^^^^^^^^

FAILURE: Build failed with an exception.

Smartphone (please complete the following information):

dcchristopher commented 4 years ago

I'd like to note that this is more of a heads up for folks regarding a potential issue with an upcoming release of Flutter. If this dev code is merged into stable, sliding_up_panel will likely cease to work unless a fix is introduced. I realize this isn't an issue with sliding_up_panel with the current stable channel of Flutter.

akshathjain commented 4 years ago

I think the current version of Flutter might already be causing issues. Closing this issue and moving the discussion over to #193.

dcchristopher commented 4 years ago

I think the current version of Flutter might already be causing issues. Closing this issue and moving the discussion over to #193.

Gotcha, I’m so sorry I didn’t see that one as a possibility of being related (runtime vs compile time). I should have checked the details.