fix unscrollable lists when slide direction is down. handle reverse lists. - Githubissues

akshathjain / sliding_up_panel

A draggable Flutter widget that makes implementing a SlidingUpPanel much easier!

https://pub.dartlang.org/packages/sliding_up_panel

Other

1.38k stars 378 forks source link

fix unscrollable lists when slide direction is down. handle reverse lists. #217

Open zakton5 opened 3 years ago

zakton5 commented 3 years ago

Fixes #215

This PR fixes the following scenarios

Scrollable content in the panel when slideDirection == SlideDirection.DOWN did not scroll at all
Strange list behavior when reverse == true for both SlideDirection.DOWN and SlideDirection.UP

To test

Run the example project
Use all 4 of the following configurations and verify that each one opens, scrolls, and closes as expected.
- List reverse: false, SlidingUpPanel slideDirection: SlideDirection:UP
- List reverse: true, SlidingUpPanel slideDirection: SlideDirection:UP
- List reverse: false, SlidingUpPanel slideDirection: SlideDirection:DOWN
- List reverse: true, SlidingUpPanel slideDirection: SlideDirection:DOWN