search

akshathjain / sliding_up_panel

A draggable Flutter widget that makes implementing a SlidingUpPanel much easier!
https://pub.dartlang.org/packages/sliding_up_panel
Other
1.36k stars 379 forks source link

PanelController does not have a dispose() method #290

Closed subzero911 closed 2 years ago

subzero911 commented 2 years ago

There's no way to dispose PanelController() instance. It will lead to memory leaks. Please add it.

subzero911 commented 2 years ago

Oh, that's my mistake. TextEditingController is extended from ValueNotifier, that should be disposed. But PaneController isn't. It also doesn't have any streams / unmanaged resources inside. So i'll close it.