Backdrop's GestureDetector should be excluded from semantics

akshathjain / sliding_up_panel

A draggable Flutter widget that makes implementing a SlidingUpPanel much easier!

https://pub.dartlang.org/packages/sliding_up_panel

Other

1.36k stars 377 forks source link

Backdrop's GestureDetector should be excluded from semantics #341

Closed tony-ditchlabs closed 3 months ago

tony-ditchlabs commented 3 months ago

Describe the bug Using the package accessibility_tools, the package flags a backdrop where backdropTapClosesPanel is true as missing a semantics label for screen readers / other assistive tech. A minor headache, but automated tests that depend on it are failing.

Workaround Setting backdropTapClosesPanel to false removes the GestureDetector from the widget tree, but it's not great UX.

To Fix Add excludeFromSemantics: true to the backdrop's GestureDetector.

tony-ditchlabs commented 3 months ago

Closing, duplicate of 168.