Scraper code for FPL Scraper. It includes the main file to take inputs & display outputs & the logic file to store scraped data. Along with the same, rspec tests & example CSV are added.
Why?
Part of Capstone Project to scrape a website which would be useful for personal use.
How?
Mentioned in Readme
Testing?
Using rspec which is mentioned in Readme as well
Changes made on TSE Review 1&2
[x] First of all, you should follow the Git Flow. Right now, you are trying to merge from development to main.
[x] You've disabled the rubocop in your scraper.rb. You shouldn't do this.
[x] In scraper.rb at lines 29 and 54 the paths are not working. After I deleted the../ from the beginning the app started working.
[x] In your readme, you mentioned d that to run tests the command is 'rspec scraper_rspec.rb'. However, rspec doesn't run with that command and I need to change it to 'rspec ./spec/scraper_rspec.rb', and then it works. PS it works with the paths without the ../ at the beginning.
[x] You can add negative test cases.
[x] You shouldn't use attr-accessor unless you have to. You can use attr-reader on your scraper.rb because you are not using this outside of the file. [Need them for rspec]
[x] When I try to run the rspec tests it returns me a time out error. [Please follow the readme instructions and install chrome in the right path]
[x] remove commented code in scraper.rb file
[x] When I tried to run the program the next error appears: Failed to read descriptor from node connection. [Please follow the readme instructions and install chrome in the right path]
[x] You should only use attr_accesor for variables that will be read and write outside the class. [ Need to use it for rspec test code ]
[x] You should only user attr_reader for variables that will be read outside the class. [ Need to use it for rspec test code ]
What?
Scraper code for FPL Scraper. It includes the main file to take inputs & display outputs & the logic file to store scraped data. Along with the same, rspec tests & example CSV are added.
Why?
Part of Capstone Project to scrape a website which would be useful for personal use.
How?
Mentioned in Readme
Testing?
Using rspec which is mentioned in Readme as well
Changes made on TSE Review 1&2
[x] First of all, you should follow the Git Flow. Right now, you are trying to merge from development to main.
[x] You've disabled the rubocop in your scraper.rb. You shouldn't do this.
[x] In scraper.rb at lines 29 and 54 the paths are not working. After I deleted the../ from the beginning the app started working.
[x] In your readme, you mentioned d that to run tests the command is 'rspec scraper_rspec.rb'. However, rspec doesn't run with that command and I need to change it to 'rspec ./spec/scraper_rspec.rb', and then it works. PS it works with the paths without the ../ at the beginning.
[x] You can add negative test cases.
[x] You shouldn't use attr-accessor unless you have to. You can use attr-reader on your scraper.rb because you are not using this outside of the file. [Need them for rspec]
[x] When I try to run the rspec tests it returns me a time out error. [Please follow the readme instructions and install chrome in the right path]
[x] remove commented code in scraper.rb file
[x] When I tried to run the program the next error appears: Failed to read descriptor from node connection. [Please follow the readme instructions and install chrome in the right path]
[x] You should only use attr_accesor for variables that will be read and write outside the class. [ Need to use it for rspec test code ]
[x] You should only user attr_reader for variables that will be read outside the class. [ Need to use it for rspec test code ]
[x] Do not edit the rubocop file