Closed gabrielsadaka closed 10 years ago
Okay when we start adding error handling I will set it up so it catches the exceptions separately, logs them and provides useful error messages.
I split up the LoadAndConnect method so LoadConnections and ConnectToRecentIp do one thing and one thing only and the caller decides what to do.
Great! This is awesome. Thanks for the fixes.
Sorry for not being clear earlier. Here are a few pointers.
About Try/Catch
Ping
method.About showing connections Responsibility of method called
LoadAndConnect
is just that - to load and to connect. It shouldn't have to check for a flag. To put it differently, the call should only be made if the flag is true. Otherwise the method shouldn't be called at all. Tell, Don't Ask.Please, fix the things and create commits. Those will be automatically added to this pull request. Then, I'll merge. Hope you understand the reasoning.