akshay2000 / XBMCRemoteRT

XBMC Remote for Windows and Windows Phone
24 stars 18 forks source link

Added flexible grid on cover page #17

Closed gabrielsadaka closed 10 years ago

akshay2000 commented 10 years ago

Sorry for not being clear earlier. Here are a few pointers.

About Try/Catch

About showing connections Responsibility of method called LoadAndConnect is just that - to load and to connect. It shouldn't have to check for a flag. To put it differently, the call should only be made if the flag is true. Otherwise the method shouldn't be called at all. Tell, Don't Ask.

Please, fix the things and create commits. Those will be automatically added to this pull request. Then, I'll merge. Hope you understand the reasoning.

gabrielsadaka commented 10 years ago

Okay when we start adding error handling I will set it up so it catches the exceptions separately, logs them and provides useful error messages.

I split up the LoadAndConnect method so LoadConnections and ConnectToRecentIp do one thing and one thing only and the caller decides what to do.

akshay2000 commented 10 years ago

Great! This is awesome. Thanks for the fixes.