search

akshay2211 / PixImagePicker

Pix is a Whatsapp image picker replica. with this, you can integrate an image picker just like WhatsApp.
Apache License 2.0
860 stars 217 forks source link

Camera Preview is distorted on Samsung mobile #12

Closed rodrigommacedo closed 6 years ago

rodrigommacedo commented 6 years ago

Camera Preview is distorted on Samsung mobile (SM-G531H - Android 5.1.1 - Mode Portrait)

akshay2211 commented 6 years ago

Hello @rodrigommacedo, Can you provide any screenshots or a bit more detailed info? Have you tried it in another hardware?

sabieber commented 6 years ago

I can reproduce the issue with the Pixel 2 XL API 26 emulator. Dont know if that helps finding the root of the issue.

Just the preview is affected, the resulting image seems fine.

image

rodrigommacedo commented 6 years ago

I tested on mobile phone z2 worked

Print Samsung SM-G531H: 0294c077-c139-4e6e-b9b0-2e4175104c28

Photo Original: unnamed

sabieber commented 6 years ago

@akshay2211 This seems to be an issue with the CameraKit library https://github.com/CameraKit/camerakit-android/issues/288

holparb commented 6 years ago

I have also experienced the same on a Xioami Mi6.

According to the CameraKit guys their 1.0.0 library update is supposed to fix this issue: https://github.com/CameraKit/camerakit-android/pull/318

I updated the library version through Gradle but the issue still persists. Is there anything else that could be done to fix it?

praslnx8 commented 6 years ago

Even I am getting these issue in Lenova K5 vibe.

waelsyrian996 commented 6 years ago

I am having the same issue on HTC devices, but I did something (with risk) and helped me. I added PixImagePicker as a module then, I changed the CameraKit version to 1.0.0 preview

check this link: https://github.com/CameraKit/camerakit-android/pull/318

and made the changes in the process of dealing with the camera and it works with me.

sabieber commented 6 years ago

@waelsyrian996 Could you perhaps create a PR of these changes?

akshay2211 commented 6 years ago

I am working on switching to Fotoapparat from Camera kit, this will provide a stable camera view, I will try to update it by next 1 or 2 days.

akshay2211 commented 6 years ago

Sorry for the delay, wasn't able to do much in last few days, The above-mentioned change is been done in new version 1.0.10.

sabieber commented 6 years ago

Why is such a major change just a change in the bugfix part of the version-number? Thats not really how semantic versioning is supposed to work 😅 Should be at least 1.1 if not 2.0

sabieber commented 6 years ago

Bug seems to be fixed on my end 👍

akshay2211 commented 6 years ago

@sabieber no issues ill convert it to 2.0 , Thank you for letting me know.