search

akshaya86 / WearOSApplication

0 stars 0 forks source link

Hrm03 integrate di database module #10

Closed akshaya86 closed 2 years ago

akshaya86 commented 2 years ago
EntyR commented 2 years ago

Please move everything ui related for another request, this request is already quite big

EntyR commented 2 years ago

Also try to test repository class where is some problems in connecting koin and room so it will be great to fix it here if you find any

akshaya86 commented 2 years ago

@EntyR Please revisit this PR .

EntyR commented 2 years ago

Did you forget to push? don't see any new commit

EntyR commented 2 years ago

About koin and room: Leave it as it is for now but for the future we need to be able to test pr before merging so you shouldn't split room into 2 different request, same with koin and ui elements I can't review and debug them properly since they not done yet

akshaya86 commented 2 years ago

Hi @EntyR

Please revisit this PR. I missed some changes files . All DI and Room module is linked in next PR .

EntyR commented 2 years ago

It's not building now

akshaya86 commented 2 years ago

@EntyR let me recheck

akshaya86 commented 2 years ago

@EntyR Please revisit this PR

EntyR commented 2 years ago

Fine now, can merge