search

akshaybhalotia / RubyEx1

Resume Writer with different file formats
0 stars 0 forks source link

Why not enforce a standard for the file generators? #4

Closed jerryjohnjacob closed 8 years ago

jerryjohnjacob commented 8 years ago

The CSV generator has a class method to write to file where as the same is an instance method in the PDF generator. And as a result, the file format lister has to go through the overhead of having to cater for both these scenarios. It would make the code in the format lister much simpler if this overhead was eliminated.

akshaybhalotia commented 8 years ago

I did some refactoring here. Please have a look.