search

akshaybhalotia / RubyEx1

Resume Writer with different file formats
0 stars 0 forks source link

The code in the file format lister seems to be suggesting a different programming pattern would be better #5

Open jerryjohnjacob opened 8 years ago

jerryjohnjacob commented 8 years ago

The FileFormatLister has been coded to work with class methods, which is okay. However, it also uses one or two class variables, which indicates that some form of state needs to be maintained globally. Using class variables is probably not the best solution and there are multiple ways to improve this.

akshaybhalotia commented 8 years ago

I did some refactoring here. Please have a look.

jerryjohnjacob commented 8 years ago

I think this has not been resolved... There is still a class variable (actions).

akshaybhalotia commented 8 years ago

Silly mistake. Changed it to instance variable. Please comment.