search

akshaybhalotia / RubyEx1

Resume Writer with different file formats
0 stars 0 forks source link

Delegation of tasks and organization of code #6

Open jerryjohnjacob opened 8 years ago

jerryjohnjacob commented 8 years ago

It would seem at a glance that the UserInteractor would handle all sorts of data input and output with the external world. However, that class takes care only of a specific portion of it. e.g. the FileFormatLister is handling the asking and acceptances of formats and choices for the same.

Furthermore, the UserInteractor decides what data attributes will get accepted. Any better place to do this?

akshaybhalotia commented 8 years ago

I did some refactoring here. Please have a look.

jerryjohnjacob commented 8 years ago

One method seems to be out of place in the UserInteractor - the write_to_file method. That does not interact with the user. This should probably move elsewhere.

akshaybhalotia commented 8 years ago

This one was consistent with the design I had in mind, but I recognize the problem you state. You won't find it in the next exercise if you have a look. Nevertheless, corrected it here too.