akshayjshah / attest

Type-safe assertion helpers for Go
https://pkg.go.dev/go.akshayshah.org/attest
MIT License
15 stars 2 forks source link

Print errors using %+v #17

Closed komuw closed 4 weeks ago

komuw commented 3 months ago

This will print extra error details(like stack traces) for errors that happen to have them

Closes: https://github.com/akshayjshah/attest/issues/16

komuw commented 3 months ago

I can't think of an easy way to write a unit test for this so I didn't.

komuw commented 3 months ago

friendly ping @akshayjshah

akshayjshah commented 4 weeks ago

Sorry for the long delay. The best way to test this is to add an error with a Format method. I pushed a commit to your branch to add some tests - take a look if you're curious!

Thanks for the contribution, and for reminding me to review this PR.

akshayjshah commented 4 weeks ago

This is included in v1.1.0, which I just tagged. Thanks again for the contribution, @komuw!