search

akshaykarle / go-mongodbatlas

A Go client library for the MongoDB Atlas API
GNU General Public License v3.0
16 stars 20 forks source link

Implementation of VPC Peering with GCP #16

Closed BrendanThompson closed 5 years ago

BrendanThompson commented 5 years ago

This implements the ability to provision an Atlas cluster with GCP peering, and is the backing change for akshaykarle/terraform-provider-mongodbatlas#80.

Relates: akshaykarle/terraform-provider-mongodbatlas#74

codecov-io commented 5 years ago

Codecov Report

Merging #16 into master will not change coverage. The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #16   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          13     14    +1     
  Lines         348    368   +20     
=====================================
+ Hits          348    368   +20
Impacted Files Coverage Δ
mongodbatlas/containers.go 100% <100%> (ø) :arrow_up:
mongodbatlas/private_ip_mode.go 100% <100%> (ø)
mongodbatlas/peers.go 100% <100%> (ø) :arrow_up:
mongodbatlas/mongodb.go 100% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 6eb79cf...a7fd82c. Read the comment docs.

gordalina commented 5 years ago

Can this be merged and released so that https://github.com/akshaykarle/terraform-provider-mongodbatlas/pull/80 can be released as well?