search

akshaykarle / terraform-provider-mongodbatlas

Terraform provider for MongoDB Atlas
Mozilla Public License 2.0
122 stars 54 forks source link

Support for provider backups in mongodbatlas_cluster #48

Closed dpiddockcmp closed 6 years ago

dpiddockcmp commented 6 years ago

Requires https://github.com/akshaykarle/go-mongodbatlas/pull/5 and a vendor update.

akshaykarle commented 6 years ago

Hello @dpiddockcmp, thank you for the PRs. I've merged in https://github.com/akshaykarle/go-mongodbatlas/pull/5, so if you run make vendor-fetch should update the dependency and we can merge it in?

codecov-io commented 6 years ago

Codecov Report

Merging #48 into master will increase coverage by 0.05%. The diff coverage is 25%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #48      +/-   ##
==========================================
+ Coverage   44.13%   44.19%   +0.05%     
==========================================
  Files          10       10              
  Lines         972      982      +10     
==========================================
+ Hits          429      434       +5     
- Misses        543      548       +5
Impacted Files Coverage Δ
mongodbatlas/resource_mongodbatlas_cluster.go 43.51% <25%> (+0.2%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d209238...2a9d8a1. Read the comment docs.

dpiddockcmp commented 6 years ago

Done.

Had some trouble with govendor: Different Canonical Packages for github.com/dghubble/sling which I "solved" by deleting the vendor/github.com/dghubble/ folder.

akshaykarle commented 6 years ago

Perfect! Thanks for the PR @dpiddockcmp :)

dpiddockcmp commented 6 years ago

Hi @akshaykarle. Could you create a point release with this PR included? Thank you :)