akshaykarle / terraform-provider-mongodbatlas

Terraform provider for MongoDB Atlas
Mozilla Public License 2.0
123 stars 54 forks source link

Support for VPC Peering with GCP #74

Closed BrendanThompson closed 5 years ago

BrendanThompson commented 5 years ago

@akshaykarle there is support for GCP VPC within MongoDB Atlas, what would be involved in getting that support into the TF provider here?

akshaykarle commented 5 years ago

Hey @BrendanThompson you will have to first add support for GCP into the go-mongodbatlas repo and then update the container resource to handle those new api fields.

It will also be helpful if you could add an acceptance test to the resource_mongodbatlas_container_test.go

Let me know if you are interested in developing this and I'm happy to assign it to you

BrendanThompson commented 5 years ago

Hey @akshaykarle, yeah assign it to me. So in order to support this we need to update the following, in this repo:

My question here is, would it make more sense to have separate resource types for GCP and AWS, perhaps as per the following:

As we are changing up the required fields ( e.g. – networkName, gcpProjectId, vpcId ) it makes sense to me to have them as separate resource files, however, I am not experienced in creating providers; in fact, this is my first time modifying a provider.

BrendanThompson commented 5 years ago

Ignore what is above, I have worked it all out, I think.