search

akshaykarle / terraform-provider-mongodbatlas

Terraform provider for MongoDB Atlas
Mozilla Public License 2.0
122 stars 54 forks source link

Implementation of Peering with GCP #80

Closed BrendanThompson closed 5 years ago

BrendanThompson commented 5 years ago

This implements the ability to provision a VPC Peered cluster with GCP.

Resolves: #74

BrendanThompson commented 5 years ago

@akshaykarle – this is due to the vendor package for akshaykarle/go-mongodbatlas not having the new fields. Let me now how you want me to proceed here.

gordalina commented 5 years ago

Can we merge this? I've tested it and works beautifully

BrendanThompson commented 5 years ago

@akshaykarle can we get an update on when/if this PR is going to be merged, as well its partner in the go-mongodbatlas repo?

codecov-io commented 5 years ago

Codecov Report

Merging #80 into master will increase coverage by 1.08%. The diff coverage is 43.9%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #80      +/-   ##
==========================================
+ Coverage   41.08%   42.17%   +1.08%     
==========================================
  Files          11       11              
  Lines        1217     1335     +118     
==========================================
+ Hits          500      563      +63     
- Misses        716      771      +55     
  Partials        1        1
Impacted Files Coverage Δ
mongodbatlas/resource_mongodbatlas_container.go 38.7% <30%> (-2.74%) :arrow_down:
...as/resource_mongodbatlas_vpc_peering_connection.go 37.1% <35.89%> (+4.53%) :arrow_up:
mongodbatlas/data_source_mongodbatlas_container.go 75% <80.55%> (+6.25%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 394e4d0...9a04456. Read the comment docs.

gordalina commented 5 years ago

Thank you!

BrendanThompson commented 5 years ago

@akshaykarle awesome! Are you able to cut a release 🚀 for these changes?

akshaykarle commented 5 years ago

Yeah, I would like to push a new release, but I first need to fix the linting errors and some broken website tests which are breaking the build- https://travis-ci.org/akshaykarle/terraform-provider-mongodbatlas/jobs/527502961

If someone wants to take a stab at fixing them, that would be great. If not, I will do it in the next few days.