search

akshaynagpal / w2n

Convert number words (eg. twenty one) to numeric digits (21)
http://w2n.readthedocs.io
MIT License
167 stars 78 forks source link

Refactor handling of three digit groups #34

Open poneill opened 5 years ago

poneill commented 5 years ago

Hi,

I've tried to refactor the handling of three digit groups a bit, and I've added a few tests to cover cases that were previously handled incorrectly. This fixes #27 (and possibly others?)

Cheers, Pat.

codecov[bot] commented 5 years ago

Codecov Report

Merging #34 into master will increase coverage by 1.51%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #34      +/-   ##
==========================================
+ Coverage    96.8%   98.31%   +1.51%     
==========================================
  Files           2        2              
  Lines         125      119       -6     
==========================================
- Hits          121      117       -4     
+ Misses          4        2       -2
Impacted Files Coverage Δ
word2number/w2n.py 97.26% <100%> (+2.13%) :arrow_up:
unit_testing.py 100% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 33aac8a...3308f3e. Read the comment docs.