search

akshayyn / cloning

Automatically exported from code.google.com/p/cloning
Other
0 stars 0 forks source link

IDumpCloned improvments #36

Open GoogleCodeExporter opened 8 years ago

GoogleCodeExporter commented 8 years ago 
Looks like both the two deepClone() methods and the cloneInternal both call 
startCloning()... makes it difficult to determine when an object is actually 
being "started".

To mirror the previous "functionality" you'd need an additional callback/method 
on the interface as previously "start>" was output followed by "clone>" 
followed by "cloned field>"

I think there is benefit in adding that additional callback on the interface.

It would also be useful if objects were passed to the callbacks instead of the 
Class of the object:
* startCloning() is passed o
* new callback (ie the "clone>" replacement) is passed o
* the field callback, cloning() is passed both o, along with fieldObject

This allows dumping details of the actual object vs just the class name.

Original issue reported on code.google.com by jklap...@gmail.com on 26 Jun 2014 at 11:48

GoogleCodeExporter commented 8 years ago 
Plus, on the upside of not having released a version since IDumpCloned() was 
introduced it's not really a breaking change ;)

Original comment by jklap...@gmail.com on 26 Jun 2014 at 11:51

GoogleCodeExporter commented 8 years ago 
Would also be nice if a "done" method was called (and passed in the object).

Original comment by jklap...@gmail.com on 10 Sep 2014 at 7:26