search

akshgpt7 / MarvellOS

A basic operating system GUI mock-up built using python's GUI module Tkinter.
20 stars 20 forks source link

Upload feature for Gallery Added #39

Open NiharikaVadlamudi opened 3 years ago

NiharikaVadlamudi commented 3 years ago
NiharikaVadlamudi commented 3 years ago

@akshgpt7 Check this out !

NiharikaVadlamudi commented 3 years ago
  1. When you upload a picture,the screen goes blank that's all . If you keep clicking NEXT , the image will be shown at the end .
  2. Can you point out exact dimensions ? I was thinking 128x128 would fit to the screen .
  3. If you don't mind could you tell me the steps? Everytime I had to delete my fork and vlone the entire repo on my pc .
akshgpt7 commented 3 years ago
  1. I did click the next button till I reached the end, but the image doesn't show. Does it work for you?
  2. Yes 128x128 will be fine for now, rest will be handled in the dynamic sizing.
  3. Basically you just need to make the changes locally to the same cloned repo, commit them and just push to this same branch (make sure it's the same branch as the PR). A few Google searches will help you if you get stuck, or feel free to ask if you don't understand :) This might help: https://docs.github.com/en/free-pro-team@latest/github/collaborating-with-issues-and-pull-requests/committing-changes-to-a-pull-request-branch-created-from-a-fork
NiharikaVadlamudi commented 3 years ago

@akshgpt7 Simple check, the sample-pictures consists of 10 gifs (orignally) , now when you add a new file there will be a new fil added under the name - sample-pic-11.gif or so to the folder. So after uploading a file check the where its stored. I am sure you'll find it there.

akshgpt7 commented 3 years ago

Yeah I did check that, it does add the image there, but smh doesn't show in the gallery. Maybe a problem at my end because if it's added to the folder, it should show up.

NiharikaVadlamudi commented 3 years ago

Might be . So, just resizing the image is sufficient right ? I guess 128 ×128 will suffice.

akshgpt7 commented 3 years ago

Yes that should do.

NiharikaVadlamudi commented 3 years ago

@akshgpt7 Pushed the code. Please check and let me know if you can see the changes.

akshgpt7 commented 3 years ago

I'm getting the following error on running the gallery: AttributeError: 'PhotoImage' object has no attribute 'resize'. Did you try running it?

NiharikaVadlamudi commented 3 years ago

@akshgpt7 Please check now.

NiharikaVadlamudi commented 3 years ago

@akshgpt7 Any issue with merging? If so let me know !

akshgpt7 commented 3 years ago

Also, I'm still getting the same error as above. Please fix that. Can you run flake8 on the code, and fix the PEP-8 violations. After merging #37, all the code conforms to PEP-8 guidelines, that'll be it

NiharikaVadlamudi commented 3 years ago

@akshgpt7 Please check now . I ran flake8 , most of them were due to * imports of tkinter (Button , Label, END ,etc ) . And they weren't even in my part of the code . The code is fine , please use - python3 for running the code .