Potential code refactor

akshgpt7 / MarvellOS

A basic operating system GUI mock-up built using python's GUI module Tkinter.

20 stars 20 forks source link

Potential code refactor #40

Closed tusharnankani closed 3 years ago

tusharnankani commented 3 years ago

PR includes:

Opening a file using with statement is preferred as function open implements the context manager protocol that releases the resource when it is outside of the with block. Not doing so requires you to manually release the resource.
When comparing a variable to True, one should always use the form if x is True or simply if x. Since boolean in python are singletons, identity checks with is operator is recommended.

akshgpt7 commented 3 years ago

Thanks for the PR @tusharnankani. The comparison with True changes are already handled in #37. I agree that the with statement change is something we should keep, so I'll merge this once #37 is finalized and merged.

akshgpt7 commented 3 years ago

@tusharnankani can you fix the merge conflicts before I merge these changes?

tusharnankani commented 3 years ago

@tusharnankani can you fix the merge conflicts before I merge these changes?

Done @akshgpt7 👍🏻

akshgpt7 commented 3 years ago

Looks good! Thanks for the PR.