search

akshitagupta15june / lane_detection_opencv

The main emphasis of this project is to find the further ways which can be used further to improve the result of lane detection algorithms. Join Discord channel for discussion.
https://discord.gg/CWqgNWbNye
MIT License
37 stars 36 forks source link

Edge detection in image is added #14

Closed bharath-acchu closed 4 years ago

bharath-acchu commented 4 years ago

Please review this PR Different Edge detection is made This includes:

  1. Laplacian method
  2. sobel method
  3. canny edge detection
Anujg935 commented 4 years ago

hi @bharath-acchu I have seen your PR but why are you changing multiple files for 1 single issue I don't know, it will be very difficult for us to account for that many files by every participant. Now coming back to edge detection, it's good you have tried to use laplacian method but why are you using the Sobel method on top of the laplacian method, and because of that, we are not getting the results of soble method correctly. SO please make it separate.

Anujg935 commented 4 years ago

Please update the PR and let me know.

bharath-acchu commented 4 years ago

Sorry for creating multiple files . It wont repeat in future . Sobel method is applied separately . It is not involved with laplacian please look into again. laplacian image is not passed into sobel, gaussian image is passed so i think it is not involved with laplacian , please look into again.

bharath-acchu commented 4 years ago

I have made the necessary changes please look into it.

Anujg935 commented 4 years ago

@bharath-acchu Great work 👍