search

aksnzhy / xlearn

High performance, easy-to-use, and scalable machine learning (ML) package, including linear model (LR), factorization machines (FM), and field-aware factorization machines (FFM) for Python and CLI interface.
https://xlearn-doc.readthedocs.io/en/latest/index.html
Apache License 2.0
3.09k stars 519 forks source link

xLearn for Windows #231

Closed etveritas closed 5 years ago

etveritas commented 5 years ago

@aksnzhy Hello, I have modified the format to make it easy to review where have changed about the code, and add doc about installation for windows.

aksnzhy commented 5 years ago

That's great!

aksnzhy commented 5 years ago

@etveritas Hi，I‘m a little busy these days and I will review this PR as soon as possible. After the Windows version released, I will send you an invitation and I hope you can be a committer of xLearn, the goal of which is to gain the most impact for large-scale sparse data processing!

etveritas commented 5 years ago

@aksnzhy okay

etveritas commented 5 years ago

About this latest commit:

  1. Correct the format of format_print.h.
  2. Simplify console setting on windows.
  3. Only set console text color when console is default setting.
aksnzhy commented 5 years ago

@aksnzhy Hello, I have modified the format to make it easy to review where have changed about the code, and add doc about installation for windows.

Thanks for the hard work! I just give some comments for the code-review. Let's improve and polish this PR until it been merged to 0.42 version. This will be a major milestone for this project.

aksnzhy commented 5 years ago

@etveritas Hi, does this PR ready for merge?

etveritas commented 5 years ago

@aksnzhy Maybe I should add some .bat file for demo

aksnzhy commented 5 years ago

@etveritas Okay, no problem.

etveritas commented 5 years ago

@aksnzhy Finish it.

aksnzhy commented 5 years ago

@etveritas Nice! I merged this PR to the master branch. I will release a new version today. Thanks for your hard work!

etveritas commented 5 years ago

@aksnzhy Great!

aksnzhy commented 5 years ago

@etveritas The 0.4.2 has been released, and I send an invitation to you for inviting you become the xLearn committer. Please check your email. Thanks again for this work!

etveritas commented 5 years ago

@aksnzhy accepted

jcr-lyxor commented 5 years ago

Just installed on windows with your guide everything works perfectly great job.