search

aksnzhy / xlearn

High performance, easy-to-use, and scalable machine learning (ML) package, including linear model (LR), factorization machines (FM), and field-aware factorization machines (FFM) for Python and CLI interface.
https://xlearn-doc.readthedocs.io/en/latest/index.html
Apache License 2.0
3.09k stars 519 forks source link

should it be "int align = kAlign * aux_size;" => "int align = kAlign;" for ftrl in ffm_score.cc line 57 #349

Open jackyhawk opened 4 years ago

jackyhawk commented 4 years ago

should it be "int align = kAlign * aux_size;" => "int align = kAlign;" for ftrl in ffm_score.cc line 57

as for "for (index_t d = 0; d < align0; d += align) {" would skip some part and not update(or calculate)

jackyhawk commented 4 years ago

for sse, it would be align=4 for sse; and if it works as xlearn, "int align = kAlign * aux_size;"

it would skip some part if k is larger than 4

jackyhawk commented 4 years ago

any suggestions?