search

aksonov / react-native-experimental-navigation

React Native ExperimentalNavigation clone (RN0.26 API) used by RNRF
Other
31 stars 53 forks source link

removed trailing comma #33

Closed yeomann closed 6 years ago

yeomann commented 6 years ago

There's a trailing comma error causing packager not to build with babel v7 as I am trying to upgrade react-native to latest 0.56.0.

ps: I am using react-native-router-flux with v3 because it is stable and I had few problems with v4 you can see screenshot here https://github.com/facebook/react-native/issues/20273#issuecomment-405888286

yeomann commented 6 years ago

Hi thanks for merging, did you need this to be publish on npm as well? because every time I remove the package and install like yarn add react-native-router-flux@3.43.0 I get the same trailing comma error. until I go to node_modules again and fix it @aksonov pls can you check, I will appreciate!

aksonov commented 6 years ago

Could you try now? I hope I don't need to change RNRF code for this

yeomann commented 6 years ago

amazing, whatever you did, worked. thank you @aksonov appreciated. looking forward for stable release of RNRF v4.

jwarykowski commented 6 years ago

@aksonov did this change ever get shipped in a react-native-router-flux v3 version?

aksonov commented 6 years ago

Sure

Balasnest commented 5 years ago

@yeomann @aksonov What is the solution for this? I am stilling getting react-native-router-flux@3.43.0 issue in react-native 0.56