Windows assets are not applied

leonskim commented 7 years ago

I've added react-native-router-flux into my project and react-native-experimental-navigation has been added as a dependency too. Although the Windows assets were committed already(https://github.com/aksonov/react-native-experimental-navigation/commit/c862d77557c28e0530bcd5cd6f95c75ff1e957bf), I'm not seeing those in node_modules/react-native-experimental-navigation/assets

$ npm i
MY_PRJ
`-- react-native-router-flux@3.37.0
  `-- react-native-experimental-navigation@0.26.10

There are only iOS and Android assets.

$ ls
'back@1.5x.android.png'  'back@1x.ios.png'      'back@3x.android.png'  'back@4x.ios.png'
'back@1.5x.ios.png'      'back@2x.android.png'  'back@3x.ios.png'
'back@1x.android.png'    'back@2x.ios.png'      'back@4x.android.png'

Can anyone confirm this?

jmarrot commented 7 years ago

Me too 👍

@aksonov an idea ?

aksonov commented 7 years ago

I'm using Mac, sorry... Any PR is welcome

Pavel.

13 янв. 2017 г., в 23:13, Jonathan MARROT notifications@github.com написал(а):

Me too 👍

@aksonov an idea ?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

jmarrot commented 7 years ago

It's just a problem of published version.

If i write in package.json : "react-native-experimental-navigation": "https://github.com/aksonov/react-native-experimental-navigation#c862d77", it's ok.

In this package : https://registry.npmjs.org/react-native-experimental-navigation/-/react-native-experimental-navigation-0.26.10.tgz theys files (for Windows) are not found.

leesolway commented 7 years ago

Having the same issue.. A new release to deploy these Windows assets would be great :)

aksonov / react-native-experimental-navigation

Windows assets are not applied #9