search

aktionariat / contracts

The public repository for all smart contracts used by Aktionariat.
Other
11 stars 11 forks source link

106 add support for eip 2612 #108

Closed rube-de closed 1 year ago

luziusmeisser commented 1 year ago

This looks good.

Question is: should we go for the alternative "uniswap" style approach that keeps the smart contract smaller, but has more overhead when processing a permit.

luziusmeisser commented 1 year ago

Some comment: I would not include the name of the token in the domain separator. It is not guaranteed to be unique, so it does not help much. At the same time, it can be changed, which can be very confusing. I would remove it from the separator.

luziusmeisser commented 1 year ago

Looks good to me. Feel free to merge.