aktionariat / contracts

The public repository for all smart contracts used by Aktionariat.
Other
11 stars 11 forks source link

126 migrate to custom errors #129

Closed rube-de closed 1 year ago

luziusmeisser commented 1 year ago

There is an error on line 119 of src/draggable/Offer.sol . Please verify the conditions again to make sure they are equivalent. Also, I would suggest to keep the checks as one-liners for better readability.

Example:

I think it is more readable to write:

    if (msg.sender != address(token)) revert EmployeeShares_InvalidSender(msg.sender);

than to write:

    if (msg.sender != address(token)) {
        revert EmployeeShares_InvalidSender(msg.sender);
    }