aktionariat / reports

Repository for public bug reports
0 stars 0 forks source link

Some questions to the smart contracts #27

Closed felivix closed 1 year ago

felivix commented 2 years ago

1) Is there a Security Audit Report for our contract (0x2AdCbeE886D23EFF5ADECC7767Bf102E4A1CE151)?

2) Shares.sol: a) What is the purpose and function under the heading "See parent method for collateral requirements"?

b) Under the heading "Transfers _amount tokens to the company and burns them" it mentions: "...this function might be called by an owner to return the shares to the company and get them back in another form under an according agreement (e.g. printed certificates or tokens on a different blockchain)" Could any token holder transfer his token to a different blockchain? If yes, how?

c) Under the heading "Sometimes, tokens are held by other smart contracts that serve as registers themselves" it mentions: "it could be a bridge to another blockchain". Could any token holder bridge his token to a different blockchain? If yes, how?

Nicola8038 commented 2 years ago
  1. We had an auditing company perform an audit on our smart contracts. The final results will be available soon and we will share them with you.

  2. a) that I don't know. @ Luzius: Can you answer that?

b) The description you found is meant in case a shareholder doesn't want tokenized shares any longer but rather transfer them to share certificates or an other more traditional form of shares. c) Yes, an investor has the possibility to bridge the share tokens two other chain e.g. layer two (this is a potential bridge that can be used to move funds to layer 2).

--

Nicola Plain

CEO (ad interim)

Aktionariat AG

CHE-453.438.437

Mobile: +41 78 614 83 47

Email: @.***

Web: https://aktionariat.com http://aktionariat.com

https://t.sidekickopen06-eu1.com/s3t/c/5/f18dQhb0S7kC8fD6XKW5dK2qR2zGCz1N5xLs7slrBrYW1S-5-y3djZr_N5F2kFW3Zpn7f1CyYXb02?te=W3R5hFj4cm2zwW4mKLS-3ZWVWBW3K2-zv1JxwY5W1Lw3rh45LM6yW1Lvd7b3T1MdDW49M7Pd1Gy6MB0&si=8000000020887941&pi=56074d42-5d6b-4552-aedd-9099b350550b

https://t.sidekickopen06-eu1.com/s3t/c/5/f18dQhb0S7kC8fD6XKW5dK2qR2zGCz1N5xLs7slrBrYW1S-5-y3djZr_N5F2kFW3Zpn7f1CyYXb02?te=W3R5hFj4cm2zwW4fQ47l4fGCmnW3Fbt5S3zcKScF43TBFPWrCS1&si=8000000020887941&pi=56074d42-5d6b-4552-aedd-9099b350550b

https://t.sidekickopen06-eu1.com/s3t/c/5/f18dQhb0S7kC8fD6XKW5dK2qR2zGCz1N5xLs7slrBrYW1S-5-y3djZr_N5F2kFW3Zpn7f1CyYXb02?te=W3R5hFj4cm2zwW4mKLS-4rCvX6W4hCVj23Fbt5SW3F7xMK41RjQSW36dwWw363mD8W3VWt0F4pmP_4W4fxxF_3C36GB0&si=8000000020887941&pi=56074d42-5d6b-4552-aedd-9099b350550b

https://t.sidekickopen06-eu1.com/s3t/c/5/f18dQhb0S7kC8fD6XKW5dK2qR2zGCz1N5xLs7slrBrYW1S-5-y3djZr_N5F2kFW3Zpn7f1CyYXb02?te=W3R5hFj4cm2zwW4fdJS31LdWZ2W3T1MdD49M7Pd0&si=8000000020887941&pi=56074d42-5d6b-4552-aedd-9099b350550b

Aktionariat AG is a company founded by Murat Ögat & Luzius Meisser, a Swiss Blockchain and Crypto Currency Pioneer.

Interested in blockchain? This article could be interesting for you: Eine Chance für den Finanzplatz | NZZ https://t.sidekickopen06-eu1.com/s3t/c/5/f18dQhb0S7kC8fD6XKW5dK2qR2zGCz1N5xLs7slrBrYW1S-5-y3djZr_N5F2kFW3Zpn7f1CyYXb02?te=W3R5hFj4cm2zwW4mKLS-41_40qW3F7smG3K53ntW41S2r143TbcQW41Yx_n3JFWPWW43P1h_3QZmG8W1GzPSM3JF3YjW3zdYNr1GBdn5W49h9zp41n_LcW41PG6b45RjbMW4t3zhP1J7CLKW22WLHc49Kv7ZW3F6hB74fN0QQ0&si=8000000020887941&pi=56074d42-5d6b-4552-aedd-9099b350550b

On Sun, 20 Feb 2022 at 16:04, felivix @.***> wrote:

1.

Is there a Security Audit Report for our contract (0x2AdCbeE886D23EFF5ADECC7767Bf102E4A1CE151)? 2.

Shares.sol: a) What is the purpose and function under the heading "See parent method for collateral requirements"?

b) Under the heading "Transfers _amount tokens to the company and burns them" it mentions: "...this function might be called by an owner to return the shares to the company and get them back in another form under an according agreement (e.g. printed certificates or tokens on a different blockchain)" Could any token holder transfer his token to a different blockchain? If yes, how?

c) Under the heading "Sometimes, tokens are held by other smart contracts that serve as registers themselves" it mentions: "it could be a bridge to another blockchain". Could any token holder bridge his token to a different blockchain? If yes, how?

— Reply to this email directly, view it on GitHub https://github.com/aktionariat/reports/issues/27, or unsubscribe https://github.com/notifications/unsubscribe-auth/ASVXWNKZ57IB6MW2WC5WAJ3U4D7GLANCNFSM5O4QU7HQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you are subscribed to this thread.Message ID: @.***>

Nicola8038 commented 2 years ago

Here is the link to the bridge: https://app.hop.exchange/#/send?token

--

Nicola Plain

CEO (ad interim)

Aktionariat AG

CHE-453.438.437

Mobile: +41 78 614 83 47

Email: @.***

Web: https://aktionariat.com http://aktionariat.com

https://t.sidekickopen06-eu1.com/s3t/c/5/f18dQhb0S7kC8fD6XKW5dK2qR2zGCz1N5xLs7slrBrYW1S-5-y3djZr_N5F2kFW3Zpn7f1CyYXb02?te=W3R5hFj4cm2zwW4mKLS-3ZWVWBW3K2-zv1JxwY5W1Lw3rh45LM6yW1Lvd7b3T1MdDW49M7Pd1Gy6MB0&si=8000000020887941&pi=a6478492-479e-4b8e-bb1c-d63d78dffac1

https://t.sidekickopen06-eu1.com/s3t/c/5/f18dQhb0S7kC8fD6XKW5dK2qR2zGCz1N5xLs7slrBrYW1S-5-y3djZr_N5F2kFW3Zpn7f1CyYXb02?te=W3R5hFj4cm2zwW4fQ47l4fGCmnW3Fbt5S3zcKScF43TBFPWrCS1&si=8000000020887941&pi=a6478492-479e-4b8e-bb1c-d63d78dffac1

https://t.sidekickopen06-eu1.com/s3t/c/5/f18dQhb0S7kC8fD6XKW5dK2qR2zGCz1N5xLs7slrBrYW1S-5-y3djZr_N5F2kFW3Zpn7f1CyYXb02?te=W3R5hFj4cm2zwW4mKLS-4rCvX6W4hCVj23Fbt5SW3F7xMK41RjQSW36dwWw363mD8W3VWt0F4pmP_4W4fxxF_3C36GB0&si=8000000020887941&pi=a6478492-479e-4b8e-bb1c-d63d78dffac1

https://t.sidekickopen06-eu1.com/s3t/c/5/f18dQhb0S7kC8fD6XKW5dK2qR2zGCz1N5xLs7slrBrYW1S-5-y3djZr_N5F2kFW3Zpn7f1CyYXb02?te=W3R5hFj4cm2zwW4fdJS31LdWZ2W3T1MdD49M7Pd0&si=8000000020887941&pi=a6478492-479e-4b8e-bb1c-d63d78dffac1

Aktionariat AG is a company founded by Murat Ögat & Luzius Meisser, a Swiss Blockchain and Crypto Currency Pioneer.

Interested in blockchain? This article could be interesting for you: Eine Chance für den Finanzplatz | NZZ https://t.sidekickopen06-eu1.com/s3t/c/5/f18dQhb0S7kC8fD6XKW5dK2qR2zGCz1N5xLs7slrBrYW1S-5-y3djZr_N5F2kFW3Zpn7f1CyYXb02?te=W3R5hFj4cm2zwW4mKLS-41_40qW3F7smG3K53ntW41S2r143TbcQW41Yx_n3JFWPWW43P1h_3QZmG8W1GzPSM3JF3YjW3zdYNr1GBdn5W49h9zp41n_LcW41PG6b45RjbMW4t3zhP1J7CLKW22WLHc49Kv7ZW3F6hB74fN0QQ0&si=8000000020887941&pi=a6478492-479e-4b8e-bb1c-d63d78dffac1

On Mon, 21 Feb 2022 at 08:05, Nicola Plain - Aktionariat < @.***> wrote:

  1. We had an auditing company perform an audit on our smart contracts. The final results will be available soon and we will share them with you.

  2. a) that I don't know. @ Luzius: Can you answer that?

b) The description you found is meant in case a shareholder doesn't want tokenized shares any longer but rather transfer them to share certificates or an other more traditional form of shares. c) Yes, an investor has the possibility to bridge the share tokens two other chain e.g. layer two (this is a potential bridge that can be used to move funds to layer 2).

--

Nicola Plain

CEO (ad interim)

Aktionariat AG

CHE-453.438.437

Mobile: +41 78 614 83 47

Email: @.***

Web: https://aktionariat.com http://aktionariat.com

https://t.sidekickopen06-eu1.com/s3t/c/5/f18dQhb0S7kC8fD6XKW5dK2qR2zGCz1N5xLs7slrBrYW1S-5-y3djZr_N5F2kFW3Zpn7f1CyYXb02?te=W3R5hFj4cm2zwW4mKLS-3ZWVWBW3K2-zv1JxwY5W1Lw3rh45LM6yW1Lvd7b3T1MdDW49M7Pd1Gy6MB0&si=8000000020887941&pi=56074d42-5d6b-4552-aedd-9099b350550b

https://t.sidekickopen06-eu1.com/s3t/c/5/f18dQhb0S7kC8fD6XKW5dK2qR2zGCz1N5xLs7slrBrYW1S-5-y3djZr_N5F2kFW3Zpn7f1CyYXb02?te=W3R5hFj4cm2zwW4fQ47l4fGCmnW3Fbt5S3zcKScF43TBFPWrCS1&si=8000000020887941&pi=56074d42-5d6b-4552-aedd-9099b350550b

https://t.sidekickopen06-eu1.com/s3t/c/5/f18dQhb0S7kC8fD6XKW5dK2qR2zGCz1N5xLs7slrBrYW1S-5-y3djZr_N5F2kFW3Zpn7f1CyYXb02?te=W3R5hFj4cm2zwW4mKLS-4rCvX6W4hCVj23Fbt5SW3F7xMK41RjQSW36dwWw363mD8W3VWt0F4pmP_4W4fxxF_3C36GB0&si=8000000020887941&pi=56074d42-5d6b-4552-aedd-9099b350550b

https://t.sidekickopen06-eu1.com/s3t/c/5/f18dQhb0S7kC8fD6XKW5dK2qR2zGCz1N5xLs7slrBrYW1S-5-y3djZr_N5F2kFW3Zpn7f1CyYXb02?te=W3R5hFj4cm2zwW4fdJS31LdWZ2W3T1MdD49M7Pd0&si=8000000020887941&pi=56074d42-5d6b-4552-aedd-9099b350550b

Aktionariat AG is a company founded by Murat Ögat & Luzius Meisser, a Swiss Blockchain and Crypto Currency Pioneer.

Interested in blockchain? This article could be interesting for you: Eine Chance für den Finanzplatz | NZZ https://t.sidekickopen06-eu1.com/s3t/c/5/f18dQhb0S7kC8fD6XKW5dK2qR2zGCz1N5xLs7slrBrYW1S-5-y3djZr_N5F2kFW3Zpn7f1CyYXb02?te=W3R5hFj4cm2zwW4mKLS-41_40qW3F7smG3K53ntW41S2r143TbcQW41Yx_n3JFWPWW43P1h_3QZmG8W1GzPSM3JF3YjW3zdYNr1GBdn5W49h9zp41n_LcW41PG6b45RjbMW4t3zhP1J7CLKW22WLHc49Kv7ZW3F6hB74fN0QQ0&si=8000000020887941&pi=56074d42-5d6b-4552-aedd-9099b350550b

On Sun, 20 Feb 2022 at 16:04, felivix @.***> wrote:

1.

Is there a Security Audit Report for our contract (0x2AdCbeE886D23EFF5ADECC7767Bf102E4A1CE151)? 2.

Shares.sol: a) What is the purpose and function under the heading "See parent method for collateral requirements"?

b) Under the heading "Transfers _amount tokens to the company and burns them" it mentions: "...this function might be called by an owner to return the shares to the company and get them back in another form under an according agreement (e.g. printed certificates or tokens on a different blockchain)" Could any token holder transfer his token to a different blockchain? If yes, how?

c) Under the heading "Sometimes, tokens are held by other smart contracts that serve as registers themselves" it mentions: "it could be a bridge to another blockchain". Could any token holder bridge his token to a different blockchain? If yes, how?

— Reply to this email directly, view it on GitHub https://github.com/aktionariat/reports/issues/27, or unsubscribe https://github.com/notifications/unsubscribe-auth/ASVXWNKZ57IB6MW2WC5WAJ3U4D7GLANCNFSM5O4QU7HQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you are subscribed to this thread.Message ID: @.***>

felivix commented 2 years ago

The Hop Exchange bridge looks very interesting. However, we presently couldn't use it to bridge our ERC20 Tokens to an L2.

@Nicola8038 is this an endorsement of the Hop Exchange bridge? The Wormhole hack and the Wonderland issue with the anonymity of a multisig signer are still fresh in our memory.

Very informative background article: https://blog.li.finance/hop-protocol-a-deep-dive-5075eddc4dd

Nicola8038 commented 2 years ago

Hop Exchange is the bridge our Blockchain Engineer Berhard is using and others at Aktionariat are using. We will get back to you with a more detailed answer at a later point in time.

--

Nicola Plain

CEO (ad interim)

Aktionariat AG

CHE-453.438.437

Mobile: +41 78 614 83 47

Email: @.***

Web: https://aktionariat.com http://aktionariat.com

https://t.sidekickopen06-eu1.com/s3t/c/5/f18dQhb0S7kC8fD6XKW5dK2qR2zGCz1N5xLs7slrBrYW1S-5-y3djZr_N5F2kFW3Zpn7f1CyYXb02?te=W3R5hFj4cm2zwW4mKLS-3ZWVWBW3K2-zv1JxwY5W1Lw3rh45LM6yW1Lvd7b3T1MdDW49M7Pd1Gy6MB0&si=8000000020887941&pi=7a445240-6f82-4691-89e2-e2f965028b7f

https://t.sidekickopen06-eu1.com/s3t/c/5/f18dQhb0S7kC8fD6XKW5dK2qR2zGCz1N5xLs7slrBrYW1S-5-y3djZr_N5F2kFW3Zpn7f1CyYXb02?te=W3R5hFj4cm2zwW4fQ47l4fGCmnW3Fbt5S3zcKScF43TBFPWrCS1&si=8000000020887941&pi=7a445240-6f82-4691-89e2-e2f965028b7f

https://t.sidekickopen06-eu1.com/s3t/c/5/f18dQhb0S7kC8fD6XKW5dK2qR2zGCz1N5xLs7slrBrYW1S-5-y3djZr_N5F2kFW3Zpn7f1CyYXb02?te=W3R5hFj4cm2zwW4mKLS-4rCvX6W4hCVj23Fbt5SW3F7xMK41RjQSW36dwWw363mD8W3VWt0F4pmP_4W4fxxF_3C36GB0&si=8000000020887941&pi=7a445240-6f82-4691-89e2-e2f965028b7f

https://t.sidekickopen06-eu1.com/s3t/c/5/f18dQhb0S7kC8fD6XKW5dK2qR2zGCz1N5xLs7slrBrYW1S-5-y3djZr_N5F2kFW3Zpn7f1CyYXb02?te=W3R5hFj4cm2zwW4fdJS31LdWZ2W3T1MdD49M7Pd0&si=8000000020887941&pi=7a445240-6f82-4691-89e2-e2f965028b7f

Aktionariat AG is a company founded by Murat Ögat & Luzius Meisser, a Swiss Blockchain and Crypto Currency Pioneer.

Interested in blockchain? This article could be interesting for you: Eine Chance für den Finanzplatz | NZZ https://t.sidekickopen06-eu1.com/s3t/c/5/f18dQhb0S7kC8fD6XKW5dK2qR2zGCz1N5xLs7slrBrYW1S-5-y3djZr_N5F2kFW3Zpn7f1CyYXb02?te=W3R5hFj4cm2zwW4mKLS-41_40qW3F7smG3K53ntW41S2r143TbcQW41Yx_n3JFWPWW43P1h_3QZmG8W1GzPSM3JF3YjW3zdYNr1GBdn5W49h9zp41n_LcW41PG6b45RjbMW4t3zhP1J7CLKW22WLHc49Kv7ZW3F6hB74fN0QQ0&si=8000000020887941&pi=7a445240-6f82-4691-89e2-e2f965028b7f

On Mon, 21 Feb 2022 at 09:37, felivix @.***> wrote:

The Hop Exchange bridge looks very interesting. @Nicola8038 https://github.com/Nicola8038 is this an endorsement of the Hop Exchange bridge? The Wormhole hack and the Wonderland issue with the anonymity of a multisig signer are still fresh in our memory. Very informative background article: https://blog.li.finance/hop-protocol-a-deep-dive-5075eddc4dd

— Reply to this email directly, view it on GitHub https://github.com/aktionariat/reports/issues/27#issuecomment-1046603347, or unsubscribe https://github.com/notifications/unsubscribe-auth/ASVXWNKNXLN4S4SOEFXIPLLU4H2U5ANCNFSM5O4QU7HQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you were mentioned.Message ID: @.***>

KostasZav commented 1 year ago

Hi @felivix

The final audit for our smart contracts can be found in the below document.

ABDK_Aktionariat_Solidity_v_2_0 (1).pdf

Regarding the rest of the questions, I think @rube-de might have some answers since he is the expert.

rube-de commented 1 year ago

2) a) the setCustomClaimCollateral function gives the owner of the smart-contract the possibility set a different erc20 token than the own token as collateral for the recovery process. More information to this in the ERC20Recoverable contract. b) the description is just telling possible use cases when this burn function is used in addition to other actions. Just burning the token does nothing. c) again just describes a possibility, not an actual situation.

In general we don't support multi-chain tokens right now. That means also we don't support any bridging.

KostasZav commented 1 year ago

Hi @felivix

Is there anything else you want us to clarify in this ticket? If yes, please let us know!

Thanks.

felivix commented 1 year ago

Thank you.