aktos-io / aecad

Open Source Circuit Board Design Software that runs on the browser and desktop

https://aktos.io/aecad

54 stars 10 forks source link

Component upgrade throws a false "false unused pins" error (non blocker issue) #98

Open ceremcem opened 2 years ago

ceremcem commented 2 years ago

Reproduction

Use a subcircuit (eg. Max232 circuit) Do not use some of its pins in the parent circuit, there by define that unused pins in no-connect: section. Any component upgrade will throw a false "false unused pins" error.

This error is not blocker, simply ignore this error.

Responsible code: https://github.com/aktos-io/aecad/blob/7d1fcdf7f5c5d5ce6e5a5ee3c703d55fc7a62415/webapps/main/pcb/tools/lib/schema/post-process-netlist.ls#L124-L174

Solution

The @_netlist object should not contain the unused, label-pin connections.