search

akubera / bigdecimal-rs

Arbitrary precision decimal crate for Rust
Other
275 stars 71 forks source link

Do not rebuild if default_precision would not change #106

Closed alamb closed 1 year ago

alamb commented 1 year ago

Closes https://github.com/akubera/bigdecimal-rs/issues/105, which explains the rationale for this fix

Here is a proposed patch to avoid rebuilding bigdecimal always

I tested locally with 

cargo test
cargo test
cargo test
..

With this patch the subsequent calls to cargo test do not force a rebuild

alamb commented 1 year ago

cc @akubera

codecov-commenter commented 1 year ago

Codecov Report

Merging #106 (94e1d42) into trunk (b80509a) will not change coverage. The diff coverage is n/a.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@           Coverage Diff           @@
##            trunk     #106   +/-   ##
=======================================
  Coverage   75.64%   75.64%           
=======================================
  Files           8        8           
  Lines        2004     2004           
  Branches     2004     2004           
=======================================
  Hits         1516     1516           
  Misses         82       82           
  Partials      406      406