Closed rukai closed 1 year ago
Merging #110 (12860dd) into trunk (6e3c04a) will not change coverage. The diff coverage is
n/a
.
:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
@@ Coverage Diff @@
## trunk #110 +/- ##
=======================================
Coverage 76.86% 76.86%
=======================================
Files 11 11
Lines 2027 2027
Branches 2027 2027
=======================================
Hits 1558 1558
Misses 86 86
Partials 383 383
did you rewrite history? This merge conflict makes no sense.
I fixed it somehow.
This looks good. Thanks.
I described here that build.rs will always trigger a rebuild on the second build (but then settle after that) https://github.com/akubera/bigdecimal-rs/issues/105#issuecomment-1644976911 and this PR fixes that issue.
The fix is just to remove the line
println!("cargo:rerun-if-changed={}", default_precision_rs_path.display());
This line doesnt make any sense because the path is an output not an input. We only want to rebuild if our inputs change not our outputs.The line was originally introduced here: https://github.com/akubera/bigdecimal-rs/commit/b35a851246465f724fde83397ab257bbef48dd32 And then a workaround that missed the root cause was introduced here: https://github.com/akubera/bigdecimal-rs/pull/106/files
I also cleaned up the whole thing because it was way more complicated than it needed to be.