akuity / kargo

Application lifecycle orchestration
https://kargo.akuity.io/
Apache License 2.0
1.55k stars 133 forks source link

feat: support github apps as auth method #2139

Closed krancour closed 3 months ago

krancour commented 3 months ago

Fixes #759

netlify[bot] commented 3 months ago

Deploy Preview for docs-kargo-akuity-io ready!

Name Link
Latest commit 19b20d9466ab859166455c01c9d79577a1db9047
Latest deploy log https://app.netlify.com/sites/docs-kargo-akuity-io/deploys/666863c19df37b00081d085b
Deploy Preview https://deploy-preview-2139.kargo.akuity.io
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 76.31579% with 18 lines in your changes missing coverage. Please review.

Project coverage is 46.13%. Comparing base (e2a8e5f) to head (b5c416d).

:exclamation: Current head b5c416d differs from pull request most recent head 19b20d9

Please upload reports for the commit 19b20d9 to get more accurate results.

Files Patch % Lines
internal/credentials/github/app.go 70.37% 14 Missing and 2 partials :warning:
internal/credentials/credentials.go 90.90% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2139 +/- ## ========================================== + Coverage 45.93% 46.13% +0.19% ========================================== Files 238 239 +1 Lines 16542 16605 +63 ========================================== + Hits 7599 7661 +62 Misses 8571 8571 - Partials 372 373 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

hiddeco commented 3 months ago

What I wanted to include in my review comment, which I wrote in another tab... The documentation on this is 💯!