fix(controller): support parsing github enterprise urls

krancour commented 3 weeks ago

Fixes #2080

netlify[bot] commented 3 weeks ago

Deploy Preview for docs-kargo-akuity-io ready!

Name	Link
Latest commit	7ace2156e3e2aeff74320702ef44781fd58359e2
Latest deploy log	https://app.netlify.com/sites/docs-kargo-akuity-io/deploys/6668c5384906180008ce000b
Deploy Preview	https://deploy-preview-2145.kargo.akuity.io
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

codecov[bot] commented 3 weeks ago

Codecov Report

Attention: Patch coverage is 80.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 46.59%. Comparing base (9aa396b) to head (7ace215).

Files	Patch %	Lines
internal/gitprovider/github/github.go	80.00%	1 Missing and 1 partial :warning:

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #2145 +/- ## ========================================== + Coverage 46.56% 46.59% +0.03% ========================================== Files 239 239 Lines 16741 16745 +4 ========================================== + Hits 7795 7803 +8 + Misses 8573 8568 -5 - Partials 373 374 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

hiddeco commented 3 weeks ago

Feels like this could potentially be easily backported to 0.7.1?

krancour commented 3 weeks ago

Feels like this could potentially be easily backported to 0.7.1?

I wouldn't have done a v0.7.1 just for this, but since we're doing one for other reasons, I'm also inclined to include it.

akuitybot commented 3 weeks ago

Successfully created backport PR for release-0.7:

2148

akuity / kargo