akuity / kargo

Application lifecycle orchestration
https://kargo.akuity.io/
Apache License 2.0
1.39k stars 114 forks source link

refactor(controller): cleanup of the credentials packages #2161

Closed krancour closed 2 weeks ago

krancour commented 2 weeks ago

After implementing a half dozen credential helpers, the commonalities between them have become more clear, so I have finally given them a common interface now and things get quite tidied up this way.

These changes are entirely structural and should not change any functionality.

netlify[bot] commented 2 weeks ago

Deploy Preview for docs-kargo-akuity-io canceled.

Name Link
Latest commit 859334b91991207577a57bec5c5bbaa01721abe0
Latest deploy log https://app.netlify.com/sites/docs-kargo-akuity-io/deploys/667039303a4e090008be7dc7
codecov[bot] commented 2 weeks ago

Codecov Report

Attention: Patch coverage is 66.35945% with 73 lines in your changes missing coverage. Please review.

Project coverage is 46.37%. Comparing base (6f3a220) to head (859334b). Report is 4 commits behind head on main.

Files Patch % Lines
internal/credentials/kubernetes/database.go 74.22% 18 Missing and 7 partials :warning:
...nternal/credentials/kubernetes/ecr/pod_identity.go 25.00% 18 Missing :warning:
...als/kubernetes/gar/workload_identity_federation.go 53.84% 12 Missing :warning:
internal/credentials/kubernetes/ecr/access_key.go 70.00% 6 Missing :warning:
internal/credentials/kubernetes/github/app.go 78.94% 4 Missing :warning:
internal/credentials/kubernetes/basic/basic.go 72.72% 2 Missing and 1 partial :warning:
.../credentials/kubernetes/gar/service_account_key.go 83.33% 3 Missing :warning:
cmd/controlplane/controller.go 0.00% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2161 +/- ## ========================================== - Coverage 46.57% 46.37% -0.20% ========================================== Files 240 242 +2 Lines 16731 16744 +13 ========================================== - Hits 7792 7765 -27 - Misses 8565 8606 +41 + Partials 374 373 -1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.