Closed krancour closed 3 days ago
Attention: Patch coverage is 85.40541%
with 27 lines
in your changes missing coverage. Please review.
Please upload report for BASE (
multi-pipelines@d98c572
). Learn more about missing BASE report.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
The main change here is that verification history is moved up a level from
FreightReference
toFreightHistoryEntry
such that verification attempts, including any associatedAnalysisRun
is now associated with a specific combination of Freight, rather than individual pieces of Freight.As has been previously discussed, once such a verification attempt succeeds, every constituent piece of Freight is marked as verified, but not claim is made as to the combination being valid.
Ready for review,
but I am still validating the changes e2e.✅Aside: I believe we should consider renaming
FreightHistoryEntry
asFreightCombination
.FreightHistoryStack
would not be renamed, but the entries in the stack would be instances ofFreightCombination
.