akuity / kargo

Application lifecycle orchestration
https://kargo.akuity.io/
Apache License 2.0
1.39k stars 114 forks source link

refactor: refactor verification process to be suitable for multiple pipelines #2206

Closed krancour closed 3 days ago

krancour commented 4 days ago

The main change here is that verification history is moved up a level from FreightReference to FreightHistoryEntry such that verification attempts, including any associated AnalysisRun is now associated with a specific combination of Freight, rather than individual pieces of Freight.

As has been previously discussed, once such a verification attempt succeeds, every constituent piece of Freight is marked as verified, but not claim is made as to the combination being valid.

Ready for review, but I am still validating the changes e2e.

Aside: I believe we should consider renaming FreightHistoryEntry as FreightCombination. FreightHistoryStack would not be renamed, but the entries in the stack would be instances of FreightCombination.

codecov[bot] commented 4 days ago

Codecov Report

Attention: Patch coverage is 85.40541% with 27 lines in your changes missing coverage. Please review.

Please upload report for BASE (multi-pipelines@d98c572). Learn more about missing BASE report.

Files Patch % Lines
internal/controller/stages/verification.go 83.33% 12 Missing and 3 partials :warning:
internal/controller/stages/stages.go 93.75% 2 Missing and 3 partials :warning:
internal/kubeclient/indexer.go 70.00% 1 Missing and 2 partials :warning:
api/v1alpha1/stage_types.go 33.33% 2 Missing :warning:
internal/controller/promotions/promotions.go 0.00% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## multi-pipelines #2206 +/- ## ================================================== Coverage ? 45.93% ================================================== Files ? 242 Lines ? 16711 Branches ? 0 ================================================== Hits ? 7677 Misses ? 8654 Partials ? 380 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.