search

akuity / kargo

Application lifecycle orchestration
https://kargo.akuity.io/
Apache License 2.0
1.39k stars 114 forks source link

chore: clarify optionality #2218

Closed blakepettersson closed 2 days ago

blakepettersson commented 2 days ago

In the CRD docs freightCreationPolicy is required, even though strictly speaking if not specified it will be set to Automatic.

netlify[bot] commented 2 days ago

Deploy Preview for docs-kargo-akuity-io ready!

Name Link
Latest commit 8f2cf463af5624db9eb26d87d1959951c5776e83
Latest deploy log https://app.netlify.com/sites/docs-kargo-akuity-io/deploys/667ed8fa2efdb50008791ec7
Deploy Preview https://deploy-preview-2218.kargo.akuity.io
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

codecov[bot] commented 2 days ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 46.30%. Comparing base (43beef0) to head (8f2cf46).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2218 +/- ## ======================================= Coverage 46.30% 46.30% ======================================= Files 242 242 Lines 16767 16767 ======================================= Hits 7764 7764 Misses 8632 8632 Partials 371 371 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

hiddeco commented 2 days ago

Think the required validation should stay put, as the help we provide of filling in a default is different from the field being optional.

krancour commented 2 days ago

Thanks @blakepettersson!