Closed krancour closed 2 days ago
Attention: Patch coverage is 82.45614%
with 20 lines
in your changes missing coverage. Please review.
Please upload report for BASE (
multi-pipelines@1b40d4c
). Learn more about missing BASE report.
Files | Patch % | Lines |
---|---|---|
internal/controller/promotions/promotions.go | 0.00% | 16 Missing :warning: |
internal/controller/promotion/git.go | 85.71% | 4 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Notes:
This works end-to-end!
Known issues:
Verifications fail for Stages with more than one current Freight. 😢 This is because the values we're setting on the
kargo.akuity.io/freight
label of an AnalysisRun is now too long.If n > 1 pieces of Freight from different origins contain artifacts from the same repository, we're not really doing anything yet to disambiguate which of the two a promotion mechanism references. You end up with the artifact from whichever of the n origins is alphabetically first.
These are are fixable, but it would be my preference to address them in a follow-up.