akuity / kargo

Application lifecycle orchestration
https://kargo.akuity.io/
Apache License 2.0
1.68k stars 142 forks source link

feature request: Customisable freight aliases #2426

Open joaoestrela opened 2 months ago

joaoestrela commented 2 months ago

Checklist

Proposed Feature

Customisable freight aliases

Motivation

With the introduction of Multi-Pipelines it would be nice to allow some customisation to freight aliases to better distinguish. It is possible to rename but generated recognisable aliases would be a great improvement.

Suggested Implementation

  1. Add a new string key to the Warehouse CRD that allows the addition of a prefix or suffix to the respective generated freights.
  2. Add a boolean key to the Warehouse CRD that enables the prefixing or suffixing of the Warehouse name to the respective generated freights.
krzwiatrzyk commented 2 months ago

Fully agree, it would be awesome to automatically generate freights with an alias equal image version (from semver) like that: image

krancour commented 2 months ago

Bear in mind that a piece of Freight is a collection of artifacts. A piece of Freight with just one artifact in it is the simple case. It may seem intuitive in that case that the Freight alias would just match the tag of your Docker image, for instance, but that doesn't generalize well. The moment you have two or more artifacts in a piece of Freight (which is common, btw) that strategy falls apart. Some kind of customization ability seems likely, eventually, but adopting a strategy of mirroring version information of a single artifact doesn't seem likely when it doesn't hold up for the common case.