akuity / kargo

Application lifecycle orchestration
https://kargo.akuity.io/
Apache License 2.0
1.55k stars 133 forks source link

Stages should support referencing of ClusterAnalysisTemplates #2481

Open jessesuen opened 1 month ago

jessesuen commented 1 month ago

Proposed Feature

Today we support project (namespace) scoped AnalysisTemplates, but Argo Rollouts also has ClusterAnalysisTemplates. Currently, Kargo Stages can't reference them.

It's been requested that Stages have the ability to reference a globally defined ClusterAnalysisTemplate so that a change to the ClusterAnalysisTemplate can affect all Stages immediately.

Motivation

A Kargo operator wishes to centrally manage some verification checks that apply to all projects/stages and are not application specific.

Suggested Implementation

Introduce clusterScope: true to the template reference (matches argo-rollouts syntax)

  verification:
    analysisTemplates:
    - name: cat-fact
      clusterScope: true 

NOTE: there would need to be a new UI component for this as well, since ClusterAnalysisTemplate would be managed outside of a single project.

BenHesketh21 commented 2 days ago

I'd be interested in doing this, I've been wanting to take a look at another issue but not wanted to take anything that's needed quickly for the v0.9.0 release since I know you are working hard to get that out.

krancour commented 1 day ago

@BenHesketh21 it's all yours. We appreciate it!