Closed fykaa closed 2 weeks ago
Name | Link |
---|---|
Latest commit | 42254547cc8597185a8e66888d9dc3adda9f1f7c |
Latest deploy log | https://app.netlify.com/sites/docs-kargo-akuity-io/deploys/66e1c5350aa62d00084cc4bb |
Deploy Preview | https://deploy-preview-2517.kargo.akuity.io |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
It looks like a few unit tests that use the credential management endpoints may need an update. Their config needs secret management enabled.
Attention: Patch coverage is 8.69565%
with 21 lines
in your changes missing coverage. Please review.
Project coverage is 48.26%. Comparing base (
a64eb0e
) to head (4225454
). Report is 1 commits behind head on main.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@rbreeze any chance we can get you to amend this PR with the bits to hide credential-management functionality when the config endpoint says its not enabled?
@fykaa @krancour Sure thing, just pushed the update 👍🏻
Added a tiny fix in 92f07be85881f3e7df6d34837893bf809536750a
Thank you @fykaa! This is great!
And @rbreeze, thanks to you as well!
Fixes: https://github.com/akuity/kargo/issues/2214
Key changes include:
Configuration updates:
EnableSecretManagement
flagClusterRole
andConfigMap
to manage secrets based on this flagvalues.yaml
andconfig.go
to incorporate the new settingAPI enhancements:
GetConfig
endpoint to includeSecretManagementEnabled
statusEndpoint adjustments:
connect.CodeUnimplemented
when secret management is disabledcc: @krancour @rbreeze