akuity / kargo

Application lifecycle orchestration
https://kargo.akuity.io/
Apache License 2.0
1.68k stars 142 forks source link

ui: improve freight discovery error tooltip #2582

Open Marvin9 opened 1 month ago

Marvin9 commented 1 month ago

Checklist

Description

When Warehouse couldn't discover one of freight, it shows an error inside tooltip in the UI. However the error is not readable directly, needs to scroll. Also there seems 2 scrollbars and redundant icons.

Screenshots

Screenshot 2024-09-26 at 2 31 13 PM (2)

Steps to Reproduce

Create invalid freight

Version

dev

Logs

Paste any relevant application logs here.
chbg commented 1 month ago

Hi! I’d like to work on this issue.

To fix the scrolling problem with error tooltips, I’m thinking of modifying the tooltip’s design. This could involve adjusting the tooltip’s max-height and setting overflow properties to ensure all content is visible without scrolling. Alternatively, we could explore truncating the message with an option to expand for more details.

Could I be assigned this issue?

Thanks!

Marvin9 commented 1 month ago

Sure, assigned to you @chbg.

ddeath commented 1 week ago

Note that if you try to copy it so you can paste it somewhere, it will open Freight detail if you click on it. Imho it should not open details page if you click on tooltip.

krancour commented 1 week ago

The tooltip is nice and all and I wouldn't suggest we remove it, and I do believe it can be improved, but I think displaying error messages clearly in the Warehouse details view would probably make it quite a bit easier for people to read and copy if necessary.

For reference, Promotions currently do this. The prominently display whatever error prevented them from succeeding in the details view.