akuity / kargo

Application lifecycle orchestration
https://kargo.akuity.io/
Apache License 2.0
1.75k stars 145 forks source link

kustomize-set-image improvements #2788

Open Brightside56 opened 1 month ago

Brightside56 commented 1 month ago

Checklist

Proposed Feature

kustomize-set-image promotion step requires setting images[].image field. Proposed feature is to make field non-required

Motivation

Requirement to additionally enumerate images for setting in manifests makes templating of promotionTemplate non-trivial in some cases (where I would like to set all images from freight allowed by requestedFreight).

When unneeded - I wouldn't like my Kargo pipeline to be much aware of how images should be set Instead I would like to avoid complex templating or offload this logic into repository with manifests where possible (and have something like render: {}

Suggested Implementation

krancour commented 1 month ago

I am neutral on this... I can 💯 see the convenience of this, but I also have a concern about whether making the behavior deviate much from the actual kustomize edit set image command won't prompt some level of confusion.

Interested in @hiddeco's opinion on this one.