Closed hiddeco closed 6 days ago
Name | Link |
---|---|
Latest commit | 3e004308a753f6013a2a34f93c6f30b6f725a9e2 |
Latest deploy log | https://app.netlify.com/sites/docs-kargo-io/deploys/6737c9d73ca6990008cb4e91 |
Deploy Preview | https://deploy-preview-2905.docs.kargo.io |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
Attention: Patch coverage is 79.42318%
with 371 lines
in your changes missing coverage. Please review.
Project coverage is 50.86%. Comparing base (
6e34eb0
) to head (3e00430
). Report is 2 commits behind head on main.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
One thing that tripped me up when reading through the changes, although this is not necessarily a new issue:
The method names verifyStageFreight()
and verifyFreightForStage()
are quite similar. The former has a good comment explaining what it does. The latter could probably stand to either be renamed or commented in a way that makes it more clear that it's about marking Freight as verified as opposed to performing verification.
The latter could probably stand to either be renamed or commented in a way that makes it more clear that it's about marking Freight as verified as opposed to performing verification.
I had this same concern, but at the time could not figure out what name would be better. "Marking" however is a good suggestion, will make the change.
This refactors the logic of the "regular" Stage reconciler into smaller chunks, with more extensive test coverage.
In addition, it adds conditions to the Stage to allow a better assessment of the state it is in over the previous
Phase
:Reconciling
: Set for as long a reconciliation is in progress on the Stage, and e.g. new changes can be expected.Ready
: Set toTrue
when the Stage is in a "steady" state.Promoting
: WhenTrue
, new Freight is actively being Promoted to the Stage.Healthy
: To indicate the health of the Stage based on the result of the health checks, compliments.status.health
.Verified
: To indicate if the Stage (Freight) has passed verification.