Closed krancour closed 5 days ago
Name | Link |
---|---|
Latest commit | 1c0e93918854ff5d932eac3a0459223779b6c9eb |
Latest deploy log | https://app.netlify.com/sites/docs-kargo-io/deploys/6738ae1c05ee06000863c9ec |
Deploy Preview | https://deploy-preview-2941.docs.kargo.io |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
Attention: Patch coverage is 84.76190%
with 16 lines
in your changes missing coverage. Please review.
Project coverage is 50.92%. Comparing base (
b75c455
) to head (1c0e939
). Report is 1 commits behind head on main.
Files with missing lines | Patch % | Lines |
---|---|---|
internal/directives/yaml_updater.go | 77.41% | 13 Missing and 1 partial :warning: |
internal/directives/helm_image_updater.go | 95.34% | 1 Missing and 1 partial :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Something is wrong here. The commit that undoes the helm-update-image
changes is missing.
Looking into it.
Fixed now.
a20442c371ac74d652fa96ac3eebaea1e6b73be7 rolls back most recent changes to helm-update-image
, but keeps non-breaking schema improvements and the additional tests that had been added.
@krancour we also need to update UI as discovery mechanism of runners/registries is not automatic.
Should I replace helm-update-image
with yaml-update
?
@Marvin9 possible to have both for now and then remove helm-update-image
in 1.2?
Fixes #2939
This PR:
Reverts most of what #2925 did to the
helm-update-image
step. There is no sense improving that step and deprecating individual fields if the entire step is going to be deprecated and replaced. This would only have led to confusion.Deprecates
helm-update-image
.Adds a new, generic
yaml-update
step that is essentially an improved/stripped down version of thehelm-update-image
step.