search

akuity / kargo

Application lifecycle orchestration
https://kargo.akuity.io/
Apache License 2.0
1.75k stars 145 forks source link

docs: warehouse selection strategies #2963

Open fykaa opened 2 days ago

fykaa commented 2 days ago

~closes https://github.com/akuity/kargo/issues/2880~

This addresses the aforementioned problem in its broadest sense.

However, we would prefer to have a separate "Working with Warehouses" guide in the long run, which can be completed within this PR.

netlify[bot] commented 2 days ago

Deploy Preview for docs-kargo-io ready!

Name Link
Latest commit 40dd06fd9005a9f276aadc7bf902dd94a21926b4
Latest deploy log https://app.netlify.com/sites/docs-kargo-io/deploys/673ca11ac0ddf60008dcbb10
Deploy Preview https://deploy-preview-2963.docs.kargo.io
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

codecov[bot] commented 2 days ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 50.91%. Comparing base (34c6128) to head (40dd06f). Report is 1 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2963 +/- ## ========================================== - Coverage 50.92% 50.91% -0.01% ========================================== Files 279 279 Lines 25180 25175 -5 ========================================== - Hits 12823 12818 -5 Misses 11666 11666 Partials 691 691 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

🚨 Try these New Features:

fykaa commented 2 days ago

However, we would prefer to have a separate "Working with Warehouses" guide in the long run, which can be completed within this PR.

I addressed this under commit 40dd06fd9005a9f276aadc7bf902dd94a21926b4. If it's not necessary for this PR, I can revert the commit.

krancour commented 2 days ago

@fykaa I can look at this, but the more immediate solution I was hoping for were comments added to relevant fields in warehouse_types.go and then codegen re-run. i.e. I want info currently not surfaced here and here to be surfaced.