akuity / kargo

Application lifecycle orchestration
https://kargo.akuity.io/
Apache License 2.0
1.75k stars 145 forks source link

fix: missing enumerated values in generated docs for warehouse #2969

Closed fykaa closed 1 day ago

fykaa commented 2 days ago

closes https://github.com/akuity/kargo/issues/2880

doc ref: https://github.com/akuity/kargo/pull/2963

netlify[bot] commented 2 days ago

Deploy Preview for docs-kargo-io ready!

Name Link
Latest commit f153333f27b2963f61a1fd67abcce79eda7b0b1b
Latest deploy log https://app.netlify.com/sites/docs-kargo-io/deploys/673dd9981332eb0008205de3
Deploy Preview https://deploy-preview-2969.docs.kargo.io
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

codecov[bot] commented 2 days ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 50.91%. Comparing base (547f686) to head (f153333). Report is 4 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2969 +/- ## ======================================= Coverage 50.91% 50.91% ======================================= Files 279 279 Lines 25175 25175 ======================================= Hits 12818 12818 Misses 11666 11666 Partials 691 691 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


🚨 Try these New Features:

krancour commented 1 day ago

This is a good start. I'll approve because I'd like to see this information out into the real world sooner rather than later, but we should follow-up in the very near future to document the behavior of each of those strategies.

akuitybot commented 1 day ago

Successfully created backport PR for release-1.0:

fykaa commented 1 day ago

we should follow-up in the very near future to document the behavior of each of those strategies.

this PR tries to talk about the behavior of each strategy