akuity / kargo

Application lifecycle orchestration
https://kargo.akuity.io/
Apache License 2.0
1.75k stars 145 forks source link

fix(api): be more thorough with checking if secret management is enabled #2973

Closed krancour closed 1 day ago

krancour commented 1 day ago

cc @Marvin9 thanks for finding.

netlify[bot] commented 1 day ago

Deploy Preview for docs-kargo-io ready!

Name Link
Latest commit 217b825a5a3a48aa871c63f24c690227c772d274
Latest deploy log https://app.netlify.com/sites/docs-kargo-io/deploys/673e3fce7e6d2c0008e6ec91
Deploy Preview https://deploy-preview-2973.docs.kargo.io
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

codecov[bot] commented 1 day ago

Codecov Report

Attention: Patch coverage is 0% with 29 lines in your changes missing coverage. Please review.

Project coverage is 50.90%. Comparing base (447ccc5) to head (217b825). Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
internal/api/create_or_update_resource_v1alpha1.go 0.00% 7 Missing :warning:
internal/api/create_resource_v1alpha1.go 0.00% 7 Missing :warning:
internal/api/delete_resource_v1alpha1.go 0.00% 7 Missing :warning:
internal/api/create_credentials_v1alpha1.go 0.00% 4 Missing :warning:
internal/api/delete_credentials_v1alpha1.go 0.00% 1 Missing :warning:
internal/api/get_credentials_v1alpha1.go 0.00% 1 Missing :warning:
internal/api/list_credentials_v1alpha1.go 0.00% 1 Missing :warning:
internal/api/update_credentials_v1alpha1.go 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2973 +/- ## ========================================== - Coverage 50.91% 50.90% -0.01% ========================================== Files 279 279 Lines 25175 25178 +3 ========================================== Hits 12818 12818 - Misses 11666 11669 +3 Partials 691 691 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


🚨 Try these New Features: