akuity / kargo

Application lifecycle orchestration
https://kargo.akuity.io/
Apache License 2.0
1.75k stars 145 forks source link

feat: allow project scoped generic kubernetes secrets #2975

Open Marvin9 opened 1 day ago

Marvin9 commented 1 day ago

This PR now allows create generic k8s secrets

TODO:

Screenshot 2024-11-20 at 6 51 09 PM (2) Screenshot 2024-11-20 at 6 55 23 PM (2) Screenshot 2024-11-20 at 6 55 56 PM (2)

netlify[bot] commented 1 day ago

Deploy Preview for docs-kargo-io ready!

Name Link
Latest commit cad6f83286e443e1340a364fa5c873b21f8ccd39
Latest deploy log https://app.netlify.com/sites/docs-kargo-io/deploys/673faf8755937f000853cdef
Deploy Preview https://deploy-preview-2975.docs.kargo.io
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

codecov[bot] commented 1 day ago

Codecov Report

Attention: Patch coverage is 38.88889% with 99 lines in your changes missing coverage. Please review.

Project coverage is 51.27%. Comparing base (27f501c) to head (cad6f83). Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
internal/api/create_credentials_v1alpha1.go 47.00% 46 Missing and 7 partials :warning:
internal/api/update_credentials_v1alpha1.go 25.80% 45 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2975 +/- ## ========================================== + Coverage 50.90% 51.27% +0.36% ========================================== Files 279 282 +3 Lines 25178 25594 +416 ========================================== + Hits 12818 13124 +306 - Misses 11669 11760 +91 - Partials 691 710 +19 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


🚨 Try these New Features:

Marvin9 commented 1 day ago

@krancour generic secret creation and listing those is ready. Till I figure out what to do for updates could you start looking at the backend code?

Also do you think its better to re-use the create resource API instead of modifying the create credentials?