search

akuity / kargo

Application lifecycle orchestration
https://kargo.akuity.io/
Apache License 2.0
1.73k stars 144 forks source link

all commits look like they came from bookkeeper #927

Closed krancour closed 12 months ago

krancour commented 1 year ago

Starting with #381, when we started re-using Bookkeeper's git package, all commits made by Kargo look like they were made by "Bookkeeper" / "bookkeeper@akuity.io" even when Bookkeeper wasn't involved.

The fix will involve Bookkeeper changes as well (and fwiw, Bookkeeper will be re-branded as something like "kargo-render"), but we should probably make the username and email address used for commits configurable.

tal-hason commented 1 year ago

Just Pointing out that #885 is some how connected to this...

krancour commented 1 year ago

Not very connected.

krancour commented 1 year ago

The fix for #957 can also fix this.

krancour commented 12 months ago

I believe #957 took care of this.